Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added user email validation for holder role guard #896

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

KulkarniShashank
Copy link
Contributor

What

Implemented email validation for users with the "holder" role in jwt strategy file.

Why

Ensures that only valid email addresses are used for check the email exists or not in token, improving data integrity and preventing potential errors related to incorrect email formats.

How

Added validation logic in the role guard to check the email format for users assigned the holder role.

Copy link

sonarcloud bot commented Aug 5, 2024

Copy link
Contributor

@GHkrishna GHkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@GHkrishna GHkrishna added the bug Something isn't working label Aug 5, 2024
@KulkarniShashank KulkarniShashank merged commit 478b91e into develop Aug 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants